8000 docs: clarify cookie domain normalization by codebytere · Pull Request #17590 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: clarify cookie domain normalization #17590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2019
Merged

docs: clarify cookie domain normalization #17590

merged 1 commit into from
Apr 2, 2019

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Mar 28, 2019 •
edited
Loading

Description of Change

Resolves #17564.

Clarifies that Chrome normalizes cookie domains to make them valid for subdomains, so hostOnly will only be true for cookies which are not specified with a domain.

cc @deepak1556

Checklist

Release Notes

Notes: Clarified cookie domain normalization behavior by Chromium in cookie documentation.

@codebytere codebytere requested a review from deepak1556 March 28, 2019 14:50
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 28, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 29, 2019
@codebytere codebytere merged commit d412582 into master Apr 2, 2019
@release-clerk
Copy link
release-clerk bot commented Apr 2, 2019

Release Notes Persisted

Clarified cookie domain normalization behavior by Chromium in cookie documentation.

@codebytere codebytere deleted the cookie-docs branch April 2, 2019 20:04
@trop
Copy link
Contributor
trop bot 8000 commented Apr 2, 2019

I have automatically backported this PR to "4-1-x", please check out #17662

@trop trop bot mentioned this pull request Apr 2, 2019
Merged
@trop trop bot removed the target/4-1-x label Apr 2, 2019
@trop trop bot mentioned this pull request Apr 2, 2019
Merged
@trop
Copy link
Contributor
trop bot commented Apr 2, 2019

I have automatically backported this PR to "5-0-x", please check out #17663

kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@codebytere @kiku-jw
docs: clarify cookie domain normalization (electron#17590)
bd0cb0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@vhashimotoo vhashimotoo vhashimotoo approved these changes

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees
No one assigned
Labels
documentation 📓
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @MarshallOfSound @vhashimotoo
0