8000 fix: add patch for framework file permissions by MarshallOfSound · Pull Request #17582 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add patch for framework file permissions #17582

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2019
Merged

fix: add patch for framework file permissions #17582

merged 1 commit into from
Mar 28, 2019

Conversation

MarshallOfSound
Copy link
Member
@MarshallOfSound MarshallOfSound commented Mar 27, 2019 •
edited
Loading

Description of Change

Fixes a permissions issue with the generated .framework files in 4.x

The patch is already present in 5.x and higher

Fixes #17581

Notes: Generated .framework files on macOS now have the correct permissions. This fixes an issue where a crash occurred if a user attempted to launch an Electron app that another user downloaded on macOS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 27, 2019
@deepak1556 deepak1556 requested a review from a team March 28, 2019 15:01
nornagon
nornagon suggested changes Mar 28, 2019
View reviewed changes
@MarshallOfSound MarshallOfSound merged commit b5f290d into 4-1-x Mar 28, 2019
@MarshallOfSound MarshallOfSound deleted the fix-framework-permissions branch March 28, 2019 20:01
@release-clerk
Copy link
release-clerk bot commented Mar 28, 2019

Release Notes Persisted

Generated .framework files on macOS now have the correct permissions. This fixes an issue where a crash occurred if a user attempted to launch an Electron app that another user downloaded on macOS.

@MarshallOfSound MarshallOfSound mentioned this pull request Mar 28, 2019
Closed
3 tasks
@soraxxo soraxxo mentioned this pull request Apr 27, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
4-2-x new-pr 🌱 PR opened recently
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarshallOfSound @nornagon @deepak1556
0