build: remove native mksnapshot for arm/arm64 #17561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we remove the patches also? |
|
Thanks for the reminder @nornagon. I was planning on removing them but forgot to do so. They are now removed as part of this PR. |
This reverts commit 6b9d5ab.
nornagon
approved these changes
Mar 27, 2019
|
Looks like the linux build is failing though? |
|
@nornagon I had started work on this in another branch and must have missed a commit. The latest commit should fix the linux build. |
|
Aha, I thought there ought to be more red lines! Thanks :) |
codebytere
approved these changes
Mar 27, 2019
|
Merging as mac failure was flake and it reran successfully here: https://circleci.com/gh/electron/electron/165267 |
|
Release Notes Persisted
|
kiku-jw
pushed a commit
to kiku-jw/electron
that referenced
this pull request
May 16, 2019
* build: remove native mksnapshot for arm/arm64
This was referenced May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Starting with Chromium 74, we can no longer build native mksnapshot binaries for arm and arm64. The decision was made by the @electron/wg-upgrades Working Group to deprecate these binaries for 5-0-x with the intention of removing them completely for 6-0-x.
This PR removes those binaries from our build and from the release. Also to make sure snapshots still work on arm/arm64, CI has been updated to create arm/arm64 snapshots using the x64 binary that are then tested on arm/arm64 hardware.
Checklist
npm testpassesRelease Notes
Notes: Removed native mksnapshot binaries for arm/arm64 as they no longer work.