8000 fix: port OSR code to new viz compositor codepath by brenca · Pull Request #17538 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: port OSR code to new viz compositor codepath #17538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Apr 17, 2019
Merged

fix: port OSR code to new viz compositor codepath #17538

merged 23 commits into from
Apr 17, 2019

Conversation

brenca
Copy link
Contributor
@brenca brenca commented Mar 25, 2019 •
edited
Loading

Description of Change

Fixes #16983.

There is an ongoing effort to upstream a large chunk of the patch to chromium (one of the guys from CEF is doing the upstreaming, and the chromium folks indicated that they are open to the patch).

TODO:

  • Windows - Software rendering
  • Windows - GPU rendering
  • MacOS - Software rendering
  • MacOS - GPU rendering
  • Linux - Software rendering
  • Linux - GPU rendering
  • Backport to 5-0-x

Checklist

Release Notes

Notes: Fixed offscreen rendering not working with viz compositor.

@brenca brenca requested a review from a team as a code owner March 25, 2019 18:13
@electron-cation electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Mar 25, 2019
@brenca brenca requested review from codebytere and zcbenz March 27, 2019 13:08
@brenca brenca changed the title fix: port OSR code to new viz compositor codepath [WIP] fix: port OSR code to new viz compositor codepath Mar 27, 2019
@brenca brenca mentioned this pull request Mar 27, 2019
Merged
5 tasks
@electron electron deleted a comment from trop bot Mar 27, 2019
codebytere
codebytere reviewed Apr 2, 2019
View reviewed changes
atom/browser/osr/osr_host_display_client.cc Outdated
@@ -0,0 +1,121 @@
// Copyright (c) 2016 GitHub, Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update copyright year

@codebytere
Copy link
Member
codebytere commented Apr 2, 2019 •
edited
Loading

For a pull request this large, it's challenging to inspect every nook and cranny as thoroughly as i'd like but based on this writeup and my understanding of the code at hand this seems to be sufficient for us to merge. I don't see any glaring issues and it's (imo) more important to release this to consumers such that the beta cycle surfaces any bugs that may be present therein and that weren't caught in initial development.

@trop
Copy link
Contributor
trop bot commented Apr 3, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #17572

@nornagon
Copy link
Contributor
nornagon commented Apr 6, 2019

one of the guys from CEF

btw, I'm pretty sure there's only one guy from CEF: Marshall Greenblatt :)

@brenca
Copy link
Contributor Author
brenca commented Apr 11, 2019

@nornagon Well, most of the viz osr work is actually done by Alexander Guettler, we have group PM with him, Marshall Greenblatt and @codebytere where we discussed how things are going. See https://bitbucket.org/chromiumembedded/cef/issues/2575

@jkleinsc
Copy link
Member

@brenca can you rebase this PR?

@codebytere codebytere merged commit 81bf158 into master Apr 17, 2019
@release-clerk
Copy link
release-clerk bot commented Apr 17, 2019

Release Notes Persisted

Fixed offscreen rendering not working with viz compositor.

@codebytere codebytere deleted the brenca/viz-osr branch April 17, 2019 21:10
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@brenca @kiku-jw
fix: port OSR code to new viz compositor codepath (electron#17538)
84fe3fe 
* fix: make OSR work with viz compositor

* fix: update OSR patch

* fix: update patch again

* fix: update viz_osr.patch for macOS

* fix: gn check warnings

* chore: no need to change SoftwareOutputDeviceWinProxy

* chore: add check in case we missed something

* fix: consider scale factor when compare size

* fix: make GPU OSR work

* fix: autofill popups with OSR

* chore: use UNIX line ending for osr_video_consumer

* chore: code is already in defined(OS_MACOSX)

* fix: share same OSR implementation on macOS

This should also fix the crash when there is navigation on macOS.

* test: osr window should not crash after navigation

* fix: make osr work on Mac properly

* fix: software osr on windows

* fix: software osr on Linux

* fix: compilation error introduced with rebase

* fix: split local surface id allocation into two

* Update osr_host_display_client_mac.mm

* chore: update copyright year

* fix: update patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@codebytere codebytere codebytere approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
app-feedback-program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable OSR in master and 5-0-x
7 participants
@brenca @codebytere @nornagon @jkleinsc @ckerr @sofianguy @zcbenz
0