8000 feat: expose colorSpace to display object by codebytere · Pull Request #17405 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: expose colorSpace to display object #17405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 19, 2019
Merged

feat: expose colorSpace to display object #17405

merged 3 commits into from
Mar 19, 2019

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Mar 15, 2019 •
edited
Loading

Description of Change

Exposes colorSpace to the display object from chromium. I did some digging into how we could potentially expose this as an object instead of a string, but there's no way to access the private member variables we'd need to do so without patching chromium, and i'd like to avoid that.

cc @miniak

Example output:

  colorSpace:
   '{primaries_d50_referred: [[0.6587, 0.3332],  [0.3206, 0.6135],  [0.1508, 0.0527]], transfer:0.0777*x + 0.0000 if x < 0.0450 else (0.9478*x + 0.0521)**2.4000 + 0.0002, matrix:RGB, range:FULL}',

Checklist

Release Notes

Notes: Exposed colorSpace to the Display object

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 15, 2019
@codebytere codebytere changed the title feat: expose colorSpace to display object [wip] feat: expose colorSpace to display object Mar 15, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 16, 2019
@codebytere codebytere marked this pull request as ready for review March 19, 2019 15:16
@codebytere codebytere changed the title [wip] feat: expose colorSpace to display object feat: expose colorSpace to display object Mar 19, 2019
@codebytere codebytere added the semver/minor backwards-compatible functionality label Mar 19, 2019
@codebytere codebytere requested a review from miniak March 19, 2019 16:51
@MarshallOfSound MarshallOfSound merged commit 1d93bc7 into master Mar 19, 2019
@release-clerk
Copy link
release-clerk bot commented Mar 19, 2019 •
edited by MarshallOfSound
Loading

Release Notes Persisted

Exposed the colorSpace property to the Display object that is returned from the screen APIs

@MarshallOfSound MarshallOfSound deleted the display-color-display branch March 19, 2019 22:12
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@codebytere @kiku-jw
feat: expose colorSpace to display object (electron#17405)
0846247 
* feat: expose colorSpace to display object

* update doc

* add a spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @miniak @MarshallOfSound
0