10000 fix: windowmenu role did not show the window list on macOS by miniak · Pull Request #16387 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: windowmenu role did not show the window list on macOS #16387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2019
Merged

fix: windowmenu role did not show the window list on macOS #16387

merged 1 commit into from
Jan 14, 2019

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Jan 14, 2019 •
edited
Loading

Description of Change

Fix #15912 properly. The whole menu needs to have window role set, as the OS appends the window list at the end of the submenu instead of replacing a single menu item. In case of windowmenu role, we cannot change the role to window, so we need to check for windowmenu in the menu controller.

The default window menu regressed in #15930, when it switched from using window role to windowmenu.

Before
screen shot 2019-01-14 at 9 09 51 am
After
screen shot 2019-01-14 at 9 48 21 am

/cc @codebytere, @sindresorhus

Checklist

Release Notes

Notes: Fixed windowmenu role not showing the window list on macOS

8000
@miniak miniak self-assigned this Jan 14, 2019
@miniak miniak requested a review from a team January 14, 2019 08:51
@miniak miniak force-pushed the miniak/fix-windowmenu-role branch from 4c669ea to 5084c47 Compare January 14, 2019 09:00
@miniak miniak requested a review from codebytere January 14, 2019 09:03
@miniak
Copy link
Contributor Author
miniak commented Jan 14, 2019

@codebytere should we backport some version of the windowmenu fix into release branches?

@miniak miniak requested a review from alexeykuzmin January 14, 2019 09:12
@codebytere
Copy link
Member
codebytere commented Jan 14, 2019 •
edited
Loading

@miniak no, it hasn't been released yet.

@alexeykuzmin alexeykuzmin merged commit 52e2576 into master Jan 14, 2019
@release-clerk
Copy link
release-clerk bot commented Jan 14, 2019

Release Notes Persisted

Fixed windowmenu role not showing the window list on macOS

@alexeykuzmin alexeykuzmin deleted the miniak/fix-windowmenu-role branch January 14, 2019 16:28
akisctx pushed a commit to akisctx/electron that referenced this pull request Jan 22, 2019
@miniak @akisctx
fix: windowmenu did not show the window list on macOS (electron#16387)
6ef516b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miniak @codebytere @alexeykuzmin
0