8000 fix: crash when calling setProgressBar on macOS by zcbenz · Pull Request #16374 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: crash when calling setProgressBar on macOS #16374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2019
Merged

fix: crash when calling setProgressBar on macOS #16374

merged 2 commits into from
Feb 4, 2019

Conversation

zcbenz
Copy link
Contributor
@zcbenz zcbenz commented Jan 12, 2019 •
edited
Loading

Description of Change

Depending on the version of macOS and macOS SDK, the system may install a default contentView for the dock, resulting in crashes like #14008.

This PR makes the code correctly check if a progress bar has been installed in dock.

I'm not sure the exact condition to trigger the crash, and it is weird that there isn't much people seeing it. But I'm seeing it on my machine, and I can verify this PR fixes it on my machine.

Checklist

Release Notes

Notes: Fix crash when calling setProgressBar on macOS

@zcbenz zcbenz requested a review from a team January 12, 2019 08:28
@codebytere codebytere changed the title Fix crash when calling setProgressBar on macOS fix: crash when calling setProgressBar on macOS Jan 15, 2019
nornagon
nornagon reviewed Jan 17, 2019
View reviewed changes
@zcbenz zcbenz force-pushed the fix-progress-bar-crash branch from af1b0b9 to 0fd7979 Compare January 21, 2019 02:58
nornagon
nornagon suggested changes Jan 22, 2019
View reviewed changes
@zcbenz zcbenz force-pushed the fix-progress-bar-crash branch from 0fd7979 to 627e8e8 Compare January 23, 2019 02:17
@codebytere codebytere merged commit 758d709 into master Feb 4, 2019
@release-clerk
Copy link
release-clerk bot commented Feb 4, 2019

Release Notes Persisted

Fix crash when calling setProgressBar on macOS

@codebytere codebytere deleted the fix-progress-bar-crash branch February 4, 2019 23:59
8000
This was referenced Feb 4, 2019
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Feb 4, 2019

I have automatically backported this PR to "3-1-x", please check out #16726

@trop
Copy link
Contributor
trop bot commented Feb 4, 2019

I have automatically backported this PR to "4-0-x", please check out #16727

@trop trop bot mentioned this pull request Feb 4, 2019
Merged
@trop trop bot removed the target/3-1-x label Feb 4, 2019
@trop trop bot removed the target/4-0-x label Feb 4, 2019
@trop
Copy link
Contributor
trop bot commented Feb 4, 2019

I have automatically backported this PR to "5-0-x", please check out #16728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zcbenz @nornagon @codebytere
0