8000 fix: enable autofill popups on mac by brenca · Pull Request #16308 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: enable autofill popups on mac #16308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 11, 2019
Merged

fix: enable autofill popups on mac #16308

merged 9 commits into from
Feb 11, 2019

Conversation

brenca
Copy link
Contributor
@brenca brenca commented Jan 7, 2019 •
edited
Loading

Description of Change

Pretty much what the label says, it looks like shuffling some code around was enough to enable autofill popups on Mac. This PR also fixes the positioning (the popup appeared below the autofilled element before, now it matches chrome (if there is no space, it appears above the element)).

Resolves #360

Checklist

Release Notes

Notes: Enabled autofill popups on Mac.

@brenca brenca requested review from nornagon, zcbenz, codebytere and a team January 7, 2019 20:41
@brenca brenca force-pushed the brenca/autofill-mac branch from d21bd3a to 4eabb8d Compare January 8, 2019 16:24
@brenca brenca changed the title fix: enable autofill popups on Mac fix: enable autofill popups on mac Jan 8, 2019
nornagon
nornagon reviewed Jan 17, 2019
View reviewed changes
@jvdoorn jvdoorn mentioned this pull request Jan 20, 2019
Open
@brenca brenca force-pushed the brenca/autofill-mac branch from 56e95b6 to 92f069a Compare January 29, 2019 20:46
@jkleinsc
Copy link
Member
jkleinsc commented Feb 1, 2019

@brenca can you rebase this PR with the latest from master? That should resolve the failing CI.

@brenca brenca force-pushed the brenca/autofill-mac branch from f1145b3 to f00787b Compare February 4, 2019 20:12
nornagon
nornagon suggested changes Feb 4, 2019
View reviewed changes
Copy link
Contributor
@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love those deleted lines :)

nornagon
nornagon reviewed Feb 5, 2019
View reviewed changes
nornagon
nornagon approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor
@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me :)

@brenca brenca force-pushed the brenca/autofill-mac branch from ba02337 to 8685356 Compare February 7, 2019 02:14
@jkleinsc jkleinsc merged commit ccc60a1 into master Feb 11, 2019
@release-clerk
Copy link
release-clerk bot commented Feb 11, 2019

Release Notes Persisted

Enabled autofill popups on Mac.

@trop trop bot mentioned this pull request Feb 11, 2019
Closed
@trop
Copy link
Contributor
trop bot commented Feb 11, 2019

I have automatically backported this PR to "5-0-x", please check out #16880

@jkleinsc jkleinsc deleted the brenca/autofill-mac branch February 11, 2019 19:39
@nornagon nornagon mentioned this pull request Apr 19, 2019
Merged
@trop
Copy link
Contributor
trop bot commented Apr 19, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #17888

1 similar comment
@trop
Copy link
Contributor
trop bot commented Apr 19, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #17888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@codebytere codebytere codebytere approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datalist elements do not work
4 participants
@brenca @jkleinsc @nornagon @codebytere
0