8000 docs: Fix typos in app.md by TySabs · Pull Request #16260 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: Fix typos in app.md #16260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2019
Merged

docs: Fix typos in app.md #16260

merged 1 commit into from
Jan 4, 2019

Conversation

TySabs
Copy link
Contributor
@TySabs TySabs commented Jan 4, 2019 •
edited by jkleinsc
Loading

Mostly added commas to prepositions that occur in the predicate. There was a misspelling and a few run-on sentences as well though.

Description of Change

Checklist

Release Notes

Notes: no-notes

@TySabs
Fix typos in app.md
84ba99f 
Mostly added commas to prepositions that occur in the predicate. There was a misspelling and a few run-on sentences as well though.
@TySabs TySabs requested a review from a team January 4, 2019 02:21
@welcome
Copy link
welcome bot commented Jan 4, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

jkleinsc
jkleinsc approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member
@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkleinsc jkleinsc changed the title Fix typos in app.md docs: Fix typos in app.md Jan 4, 2019
@jkleinsc
Copy link
Member
jkleinsc commented Jan 4, 2019

Merging as CI failure is unrelated to doc change.

@jkleinsc jkleinsc merged commit 2117524 into electron:master Jan 4, 2019
@release-clerk
Copy link
release-clerk bot commented Jan 4, 2019 •
edited by nornagon
Loading

No Release Notes

@welcome
Copy link
welcome bot commented Jan 4, 2019

Congrats on merging your first pull request! 🎉🎉🎉

akisctx pushed a commit to akisctx/electron that referenced this pull request Jan 22, 2019
@TySabs @akisctx
Fix typos in app.md (electron#16260)
78d55e2 
Mostly added commas to prepositions that occur in the predicate. There was a misspelling and a few run-on sentences as well though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TySabs @jkleinsc
0