chore: disable nodeIntegration / webviewTag by default #16235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d47d14e to
3977d2f
Compare
3 tasks
3977d2f to
0cba8ab
Compare
ab85ebc to
c3fd1b8
Compare
c20b5fd to
d5a3c98
Compare
d5a3c98 to
418e63d
Compare
alexeykuzmin
approved these changes
Jan 7, 2019
| SetDefaultBoolIfUndefined(options::kNodeIntegrationInWorker, false); | ||
| SetDefaultBoolIfUndefined(options::kWebviewTag, node); | ||
| SetDefaultBoolIfUndefined(options::kWebviewTag, false); | ||
| SetDefaultBoolIfUndefined(options::kSandbox, false); | ||
| SetDefaultBoolIfUndefined(options::kNativeWindowOpen, false); | ||
| SetDefaultBoolIfUndefined(options::kContextIsolation, false); |
There was a problem hiding this comment.
This default was also deprecated
There was a problem hiding this comment.
@MarshallOfSound I know, this one will be handled in a separate PR.
codebytere
approved these changes
Jan 7, 2019
|
Release Notes Persisted
|
akisctx
pushed a commit
to akisctx/electron
that referenced
this pull request
Jan 22, 2019
4 tasks
deepak1556
pushed a commit
to microsoft/vscode
that referenced
this pull request
May 8, 2019
The default values have been flipped for security in electron/electron#16235
deepak1556
pushed a commit
to microsoft/vscode
that referenced
this pull request
May 10, 2019
The default values have been flipped for security in electron/electron#16235
deepak1556
pushed a commit
to microsoft/vscode
that referenced
this pull request
May 16, 2019
The default values have been flipped for security in electron/electron#16235
deepak1556
pushed a commit
to microsoft/vscode
that referenced
this pull request
Jun 4, 2019
The default values have been flipped for security in electron/electron#16235
deepak1556
pushed a commit
to microsoft/vscode
that referenced
this pull request
Jun 4, 2019
The default values have been flipped for security in electron/electron#16235
deepak1556
added a commit
to microsoft/vscode
that referenced
this pull request
Jun 14, 2019
The default values are now flipped electron/electron#16235
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The previous default values have been deprecated in Electron 4.0. Follow up to #15045 and #16004.
BREAKING CHANGE
Checklist
npm testpassesRelease Notes
Notes: The default values of
nodeIntegrationandwebviewTagare nowfalseto improve security.