8000 feat: promisify app.dock.show() by codebytere · Pull Request #16904 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: promisify app.dock.show() #16904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2019
Merged

feat: promisify app.dock.show() #16904

merged 2 commits into from
Feb 13, 2019

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Feb 12, 2019 •
edited
Loading

Description of Change

Resolves #13047.

app.dock.show() was previously an asynchronous function that did not take a callback, so devs needed to employ unsavory timeouts and other things in order to give deterministic behavior to their users. This converts that method to return a Promise, which ameliorates that issue and also serves the modernization initiative.

cc @miniak @deepak1556 @ckerr @MarshallOfSound

Checklist

Release Notes

Notes: Converted app.dock.show() such that it now returns a Promise.

@codebytere codebytere requested review from a team February 12, 2019 15:58
@codebytere codebytere changed the title feat: promisify app.dock.show [wip] feat: promisify app.dock.show Feb 12, 2019
@MarshallOfSound
Copy link
Member

Only comment, is it at all possible to test this?

@codebytere codebytere added the semver/major incompatible API changes label Feb 12, 2019
@codebytere codebytere changed the title [wip] feat: promisify app.dock.show feat: promisify app.dock.show Feb 12, 2019
@codebytere
Copy link
Member Author

i'm not sure how CI would react to this but i can test that the promise resolves i guess?

@codebytere codebytere changed the title feat: promisify app.dock.show feat: promisify app.dock.show() Feb 12, 2019
@codebytere
Copy link
Member Author 
app module BrowserWindow events should emit remote-require event when remote.require() is invoked - should emit remote-require event when remote.require() is invoked

flaked on linux x64 which is unrelated.

@codebytere codebytere merged commit ca83d36 into master Feb 13, 2019
@release-clerk
Copy link
release-clerk bot commented Feb 13, 2019

Release Notes Persisted

Converted app.dock.show() such that it now returns a Promise.

@codebytere codebytere deleted the promise-dock-show branch February 13, 2019 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
semver/major incompatible API changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @MarshallOfSound
0