8000 chore: disable the remote module in devtools / chrome extension background scripts by miniak · Pull Request #16866 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: disable the remote module in devtools / chrome extension background scripts #16866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2019
Merged

chore: disable the remote module in devtools / chrome extension background scripts #16866

merged 2 commits into from
Feb 11, 2019

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Feb 11, 2019 •
edited
Loading

Description of Change

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@miniak miniak added the wip ⚒ label Feb 11, 2019
@miniak miniak self-assigned this Feb 11, 2019
@miniak miniak requested a review from a team February 11, 2019 00:12
@miniak miniak force-pushed the miniak/devtools-disable-remote branch from 37d6442 to bce76f8 Compare February 11, 2019 01:18
@miniak miniak force-pushed the miniak/devtools-disable-remote branch from bce76f8 to 75ce55f Compare February 11, 2019 01:28
@miniak miniak changed the title [wip] chore: disable the remote module in devtools / chrome extension background scripts chore: disable the remote module in devtools / chrome extension background scripts Feb 11, 2019
@miniak miniak removed the wip ⚒ label Feb 11, 2019
@miniak
Copy link
Contributor Author
miniak commented Feb 11, 2019

@MarshallOfSound, @nornagon can you please review?

alexeykuzmin
alexeykuzmin approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor
@alexeykuzmin alexeykuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it shouldn't break anything.

MarshallOfSound
MarshallOfSound requested changes Feb 11, 2019
View reviewed changes
Copy link
Member
@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for clarification

@jkleinsc jkleinsc merged commit d8ba127 into master Feb 11, 2019
@release-clerk
Copy link
release-clerk bot commented Feb 11, 2019

No Release Notes

@jkleinsc jkleinsc deleted the miniak/devtools-disable-remote branch February 11, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miniak @alexeykuzmin @MarshallOfSound @jkleinsc
0