feat: add Touch ID authentication support for macOS #16707
Conversation
bb3dec9 to
3273849
Compare
| @@ -93,6 +93,8 @@ void SystemPreferences::BuildPrototype( | |||
| .SetMethod("setAppLevelAppearance", | |||
| &SystemPreferences::SetAppLevelAppearance) | |||
| .SetMethod("getSystemColor", &SystemPreferences::GetSystemColor) | |||
| .SetMethod("isTouchIDAvailable", &SystemPreferences::IsTouchIDAvailable) | |||
| .SetMethod("promptTouchID", &SystemPreferences::PromptTouchID) | |||
There was a problem hiding this comment.
Is SystemPreferences the right place for this functionality? It doesn't seem preference-related.
There was a problem hiding this comment.
i thought about this too, but wasn't sure there was any more appropriate place 🤔
On Mac, this is where one would modify and deal with settings for TouchID though, so i think it's best of our available options
1d51efc to
679f72a
Compare
f4f653c to
c6bbe88
Compare
Clarify how `systemPreferences.canPromptTouchID()` and `systemPreferences.promptTouchID()` behave on older versions of macOS.
|
I gotta forward-declare the instance method update: 🍐'd through it |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "5-0-x", please check out #16952 |
|
Was this eventually removed from 5.0x? It doesn't look like systemPreferences module has these methods anymore. And they are also missing in the documentation |
|
@alchaplinsky this was never backported to 5; it's only present in 6 onward. Online documentation reflects the latest stable version (5-0-x) so that's why it's not present there either. |
|
@codebytere Ok, got it. Thank you for response. Will try out v6. |
How does one “set Access Control Constants like kSecAccessControlUserPresence on their keychain entry”? |
Description of Change
Resolves #16699.
This PR adds Touch ID authentication support for macOS with two new
SystemPreferencesmethods.systemPreferences.promptForTouchID()returns a Promise that resolves withtrueif successful and rejects with an error message if authentication could not be completed.systemPreferences.isTouchIDAvailable()returns a Boolean that'strueif this device is a Mac running a supported OS that has the necessary hardware for Touch ID andfalseotherwise.Checklist
npm testpassesRelease Notes
Notes: Added native Touch ID authentication support for macOS.