8000 docs: change of previously wrong added Polish emoji into proper one by robertgrzonka · Pull Request #16700 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: change of previously wrong added Polish emoji into proper one #16700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2019
Merged

docs: change of previously wrong added Polish emoji into proper one #16700

merged 2 commits into from
Feb 11, 2019

Conversation

robertgrzonka
Copy link
Contributor
@robertgrzonka robertgrzonka commented Feb 2, 2019 •
edited by jkleinsc
Loading

Description of Change

Added Polish flag to list of translations

Checklist

Release Notes

Notes: no-notes

Change Polish flag
fbd497a 
* Change of previously setuped flag of Monaco to Polish flag
@robertgrzonka robertgrzonka requested a review from a team February 2, 2019 13:27
@welcome
Copy link
welcome bot commented Feb 2, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

jkleinsc
jkleinsc requested changes Feb 11, 2019
View reviewed changes
Copy link
Member
@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertgrzonka thank you for your PR. The emoji you removed is for the Indonesian translation which Electron does support. It appears that we did not have a Polish emoji, so instead of replacing the Indonesian one, can you add the Polish one?

fix: change flags
187a94f 
* add Indonesian flag at former place
* append Polish flag at the end
robertgrzonka
robertgrzonka commented Feb 11, 2019
View reviewed changes
Copy link
Contributor Author
@robertgrzonka robertgrzonka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkleinsc hello there! Thanks for response. Sorry for my mistake, I was quite sure flag was from Monaco 🇲🇨, didn't even know Indonesia 🇮🇩 had almost the same.

I put Indonesian flag in former place and append Polish flag at the end. Hope everything will work this time :)

@jkleinsc
Copy link
Member

Merging as CI failures unrelated to doc change.

@jkleinsc jkleinsc merged commit a3cdf46 into electron:master Feb 11, 2019
@release-clerk
Copy link
release-clerk bot commented Feb 11, 2019

Release Notes Persisted

no-notes
9683

@welcome
Copy link
welcome bot commented Feb 11, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@robertgrzonka robertgrzonka deleted the patch-1 branch February 12, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertgrzonka @jkleinsc
0