8000 feat: promisify contentTracing.getCategories() by codebytere · Pull Request #16624 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: promisify contentTracing.getCategories() #16624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2019
Merged

feat: promisify contentTracing.getCategories() #16624

merged 1 commit into from
Feb 2, 2019

Conversation

codebytere
Copy link
Member

Description of Change

Backport of #16583.

cc @ckerr

Checklist

Release Notes

Notes: Converted contentTracing.getCategories() to return a promise instead taking a callback.

@codebytere codebytere requested review from a team January 30, 2019 20:45
@codebytere codebytere changed the base branch from master to 5-0-x January 30, 2019 20:46
< 8000 div class="TimelineItem-badge ">
@codebytere codebytere changed the title Getcategories bp feat: promisify contentTracing.getCategories() Jan 30, 2019
@codebytere codebytere added backport This is a backport PR 5-0-x labels Jan 30, 2019
@codebytere
Copy link
Member Author

This shouldn't be merged until it's rebased on #16643

@codebytere
feat: promisify contentTracing.getCategories() (#16583)
7c83937 
* feat: promisify contentTracing.getCategories()

* deprecate contentTracing/getCategories
@codebytere codebytere merged commit 6d76da5 into 5-0-x Feb 2, 2019
@release-clerk
Copy link
release-clerk bot commented Feb 2, 2019

Release Notes Persisted

Converted contentTracing.getCategories() to return a promise instead taking a callback.

@codebytere codebytere deleted the getcategories-bp branch February 12, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
5-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @ckerr
0