8000 feat: Add API to inspect a Shared Worker by michtsu · Pull Request #16615 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Add API to inspect a Shared Worker #16615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2019
Merged

feat: Add API to inspect a Shared Worker #16615

merged 1 commit into from
Feb 1, 2019

Conversation

michtsu
Copy link
Contributor
@michtsu michtsu commented Jan 30, 2019

Description of Change

This change adds a new inspectSharedWorker() API to enable opening devtools for a shared worker.

Checklist

Release Notes

notes: Added new inspectSharedWorker() API to enable opening devtools for a shared worker.

@michtsu michtsu requested review from a team January 30, 2019 17:21
@welcome
Copy link
welcome bot commented Jan 30, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@michtsu michtsu changed the title devtools: Add API to inspect shared worker. feat: Add API to inspect shared worker. Jan 30, 2019
@alexeykuzmin alexeykuzmin changed the title feat: Add API to inspect shared worker. feat: Add API to inspect a Shared Worker Jan 30, 2019
@ckerr ckerr added the semver/minor backwards-compatible functionality label Jan 30, 2019
ckerr
ckerr approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member
@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarshallOfSound
Copy link
Member

Closing and reopening to trigger new Archeologist

@alexeykuzmin
Copy link
Contributor

@michtsu Could you please rebase your branch onto the latest master once #16610 is merged?

@alexeykuzmin
Copy link
Contributor

@michtsu, #16610 was merged a few hours ago.

@michtsu michtsu force-pushed the michtsu/debugSharedWorker branch from 206957f to 770bb4c Compare January 31, 2019 20:39
@jkleinsc jkleinsc closed this Feb 1, 2019
@jkleinsc jkleinsc reopened this Feb 1, 2019
@jkleinsc
Copy link
Member
jkleinsc commented Feb 1, 2019

For some reason, CircleCI didn't trigger for this PR. I pulled down the changes into a branch and triggered CircleCI here: https://github.com/electron/electron/runs/57810949

@michtsu
Copy link
Contributor Author
michtsu commented Feb 1, 2019

For some reason, CircleCI didn't trigger for this PR. I pulled down the changes into a branch and triggered CircleCI here: https://github.com/electron/electron/runs/57810949

Looks like CI is passing now - @jkleinsc can you merge it? Thanks!

@codebytere codebytere merged commit 392458b into electron:master Feb 1, 2019
@release-clerk
Copy link
release-clerk bot commented Feb 1, 2019

Release Notes Persisted

Added new inspectSharedWorker() API to enable opening devtools for a shared worker.

@welcome
Copy link
welcome bot commented Feb 1, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@trop trop bot mentioned this pull request Feb 1, 2019
Closed
@trop
Copy link
Contributor
trop bot commented Feb 1, 2019

I have automatically backported this PR to "5-0-x", please check out #16681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@miniak miniak miniak approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@michtsu @MarshallOfSound @alexeykuzmin @jkleinsc @ckerr @miniak @codebytere
0