10000 feat: promisify contentTracing.getTraceBufferUsage() by codebytere · Pull Request #16600 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: promisify contentTracing.getTraceBufferUsage() #16600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 13, 2019
Merged

feat: promisify contentTracing.getTraceBufferUsage() #16600

merged 4 commits into from
Feb 13, 2019

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Jan 29, 2019 •
edited
Loading

Description of Change

Promisify contentTracing.getTraceBufferUsage().

NB: this PR required backwards-incompatible changes and thus cannot be backported to 5-0-x.

cc @ckerr @deepak1556

Checklist

Release Notes

Notes: Converted contentTracing.getTraceBufferUsage() to return a Promise instead of taking a callback.

@codebytere codebytere requested review from a team January 29, 2019 23:53
miniak
miniak requested changes Jan 30, 2019
View reviewed changes
@codebytere codebytere force-pushed the promisify-tracebufferusage branch 2 times, most recently from 320fe26 to 8c5730a Compare January 30, 2019 17:03
ckerr
ckerr requested changes Jan 30, 2019
View reviewed changes
@codebytere codebytere requested a review from ckerr January 31, 2019 03:50
@codebytere codebytere force-pushed the promisify-tracebufferusage branch 2 times, most recently from 11a4e08 to ccf5b58 Compare January 31, 2019 21:57
shahzadlone
shahzadlone reviewed Feb 1, 2019
View reviewed changes
ckerr
ckerr approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member
@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

lib/common/api/deprecate.js
})
}
},

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codebytere codebytere force-pushed the promisify-tracebufferusage branch from ccf5b58 to fa6fa7e Compare February 13, 2019 05:03
@codebytere codebytere force-pushed the promisify-tracebufferusage branch from fa6fa7e to 89c1685 Compare February 13, 2019 19:27
@codebytere codebytere merged commit fed5b99 into master Feb 13, 2019
@release-clerk
Copy link
release-clerk bot commented Feb 13, 2019

Release Notes Persisted

Converted contentTracing.getTraceBufferUsage() to return a Promise instead of taking a callback.

@codebytere codebytere deleted the promisify-tracebufferusage branch February 13, 2019 21:25
@codebytere
Copy link
Member Author

/trop run backport-to 5-0-x

@trop
Copy link
Contributor
trop bot commen 8000 ted Feb 13, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop
Copy link
Contributor
trop bot commented Feb 13, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@codebytere
Copy link
Member Author

sadness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@shahzadlone shahzadlone shahzadlone left review comments

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codebytere @ckerr @miniak @shahzadlone @jkleinsc
0