8000 chore: Move webFrame scheme privilege methods to main process (backport: 5-0-x) by trop[bot] · Pull Request #16585 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Move webFrame scheme privilege methods to main process (backport: 5-0-x) #16585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

chore: Move webFrame scheme privilege methods to main process (backport: 5-0-x) #16585

wants to merge 12 commits into from

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Jan 29, 2019

Backport of #16416

See that PR for details.

Notes: Moved webFrame custom scheme APIs to browser process under protocol

@trop trop bot requested review from a team January 29, 2019 07:11
@trop trop bot mentioned this pull request Jan 29, 2019
Merged
6 tasks
@trop trop bot added 5-0-x backport This is a backport PR labels Jan 29, 2019
miniak
miniak requested changes Jan 29, 2019
View reviewed changes
Copy link
Contributor
@miniak miniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are issues with the original PR, which need to be fixed.

@codebytere
Copy link
Member

@miniak i'll close this out and it should be manually backported then!

@codebytere codebytere closed this Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak requested changes

Assignees
No one assigned
Labels
5-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codebytere @miniak @nitsakh @deepak1556
0