fix: reject with error when url not loaded #16571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Release Notes Persisted
|
deepak1556
reviewed
Jan 29, 2019
| } | ||
|
|
||
| GURL url = web_contents()->GetLastCommittedURL(); | ||
| if (!url.is_valid()) { |
There was a problem hiding this comment.
When would a committed url be invalid ? Its a virtual url generated by the navigation controller. The DCHECK you hit is probably the other url that should be encompassed isn't recognized, in which case try using visible URL. Also using the result of committed URL to test page loading state is not a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When a user tried to call
webContents.hasServiceWorker()on awebContentsthat hadn't yet loaded a valid URL, a DCHECK would get triggered. This prevents unexplained behavior for the end user by clearly rejecting with an error whenwebContents.hasServiceWorker()is called and there is no valid file or url in which to check for the presence of a ServiceWorker.cc @ckerr
Checklist
npm testpassesRelease Notes
Notes: Ensured that
webContents.hasServiceWorker()rejects with an error for invalid URLs.