8000 docs: fix web-request.md listener signatures in electron.d.ts by miniak · Pull Request #16485 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: fix web-request.md listener signatures in electron.d.ts #16485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2019
Merged

docs: fix web-request.md listener signatures in electron.d.ts #16485

merged 1 commit into from
Jan 22, 2019

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Jan 22, 2019 •
edited
Loading

Description of Change

Fixes listener being generated as Function for onBeforeSendHeaders and onHeadersReceived.

/cc @alexeykuzmin, @codebytere

Checklist

Release Notes

Notes: Fixed onBeforeSendHeaders / onSendHeaders listener signatures in electron.d.ts.

@miniak miniak requested a review from a team January 22, 2019 13:34
@miniak miniak force-pushed the miburda/web-request-docs branch from 4162685 to e214ae1 Compare January 22, 2019 13:37
@miniak miniak self-assigned this Jan 22, 2019
@miniak miniak added the 4-2-x label Jan 22, 2019
@miniak miniak added target/4-0-x and removed 4-2-x labels Jan 22, 2019
@BinaryMuse BinaryMuse merged commit dbc5f67 into master Jan 22, 2019
@release-clerk
Copy link
release-clerk bot commented Jan 22, 2019

Release Notes Persisted

Fixed onBeforeSendHeaders / onSendHeaders listener signatures in electron.d.ts.

@BinaryMuse BinaryMuse deleted the miburda/web-request-docs branch January 22, 2019 16:46
@trop trop bot mentioned this pull request Jan 22, 2019
Merged
@trop
Copy link
Contributor
trop bot commented Jan 22, 2019

I have automatically backported this PR to "4-0-x", please check out #16487

@trop trop bot removed the target/4-0-x label Jan 22, 2019
@trop trop bot mentioned this pull request Jan 22, 2019
Merged
@trop trop bot added the in-flight/4-0-x label Jan 22, 2019
@trop
Copy link
Contributor
trop bot commented Jan 22, 2019

I have automatically backported this PR to "3-1-x", please check out #16488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@ppontes ppontes ppontes approved these changes

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miniak @alexeykuzmin @MarshallOfSound @ppontes @BinaryMuse
0