feat: promisify cookies api #16464
Merged
feat: promisify cookies api #16464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
codebytere
reviewed
Jan 23, 2019
codebytere
reviewed
Jan 23, 2019
codebytere
reviewed
Jan 23, 2019
codebytere
requested changes
8000
Jan 23, 2019
36e8bc6 to
da6c405
Compare
|
Needs electron/typescript-definitions#122 to land |
|
Release Notes Persisted
|
codebytere
pushed a commit
that referenced
this pull request
Feb 2, 2019
* feat: promisify the Cookie API * chore: update specs to test promisified cookies * chore: add deprecate wrapper for cookie callback API * docs: update docs to cookie promise changes * chore: remove redundant namespace use * docs: improve cookie example * docs: restore docs for cookie callback API * chore: restore cookie callback tests * fix: syntax of cookie promise return types
6 tasks
codebytere
added a commit
that referenced
this pull request
Feb 3, 2019
* feat: promisify cookies api (#16464) * feat: promisify the Cookie API * chore: update specs to test promisified cookies * chore: add deprecate wrapper for cookie callback API * docs: update docs to cookie promise changes * chore: remove redundant namespace use * docs: improve cookie example * docs: restore docs for cookie callback API * chore: restore cookie callback tests * fix: syntax of cookie promise return types * fix: use new promisify helper
|
This version introduced a break into my app. In particular, some cookies are not being retrieved when using cookies.get (with filter object using url) even if the new promisified version used. The cookies that are not retrieved have the following attributes different from those retrieved: Secure; HttpOnly; SameSite=Strict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Promisifies the cookie API.
CC @codebytere
Checklist
npm testpassesRelease Notes
Notes: Added Promise support for the Cookies API.