8000 fix: correctly handle IPC for promise-based methods by codebytere · Pull Request #16433 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: correctly handle IPC for promise-based methods #16433

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2019
Merged

fix: correctly handle IPC for promise-based methods #16433

merged 1 commit into from
Jan 17, 2019

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Jan 17, 2019 •
edited
Loading

Description of Change

Pulling this PR out of #16410, since zoomLevel and zoomFactor no longer need to be retrieved in an async manner. This PR takes into account async methods that return a promise as separate entities from those that simply take callbacks, and ensures that they are appropriately handled by ipc.

/cc @MarshallOfSound

Checklist

Release Notes

Notes: Fixed an issue with promise methods not resolving correctly over ipc in the renderer process.

@codebytere codebytere requested a review from a team January 17, 2019 16:08
@codebytere codebytere merged commit 720197f into master Jan 17, 2019
@release-clerk
Copy link
release-clerk bot commented Jan 17, 2019

Release Notes Persisted

Fixed an issue with promise methods not resolving correctly over ipc in the renderer process.

@codebytere codebytere deleted the fix-ipc-passing-async branch January 17, 2019 20:09
@trop
Copy link
Contributor
trop bot commented Jan 17, 2019

I was unable to backport this PR to "3-1-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor
trop bot commented Jan 17, 2019

I was unable to backport this PR to "4-0-x" cleanly;
you will need to perform this backport manuall 8000 y.

akisctx pushed a commit to akisctx/electron that referenced this pull request Jan 22, 2019
@codebytere @akisctx
fix: correctly handle IPC for promise-based methods (electron#16433)
8b78839
codebytere added a commit that referenced this pull request Jan 31, 2019
@codebytere
fix: correctly handle IPC for promise-based methods (#16433)
ecbcf59
@codebytere codebytere mentioned this pull request Jan 31, 2019
Merged
6 tasks
codebytere added a commit that referenced this pull request Feb 5, 2019
@codebytere
fix: correctly handle IPC for promise-based methods (#16433) (#16654)
0b7680a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignee 4A36 s
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @MarshallOfSound
0