Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eli-schwartz
suggested changes
Oct 25, 2018
docs/api/environment-variables.md
Outdated
| @@ -80,6 +80,16 @@ Don't attach to the current console session. | |||
|
|
|||
| Don't use the global menu bar on Linux. | |||
|
|
|||
| ### `ELECTRON_DEFAULT_TRASH` _Linux_ | |||
There was a problem hiding this comment.
Suggested change
| ### `ELECTRON_DEFAULT_TRASH` _Linux_ | |
| ### `ELECTRON_TRASH` _Linux_ |
The environment variable is ELECTRON_TRASH, the C++ compiler macro used to define the default trash implementation is ELECTRON_DEFAULT_TRASH.
Otherwise looks good to me, thanks for working on this. :)
There was a problem hiding this comment.
oh whoops, thanks for catching this; fixed!
773642c to
0a308ab
Compare
ckerr
approved these changes
Oct 26, 2018
| * `trash-cli` | ||
| * `kioclient5` | ||
| * `kioclient` | ||
|
|
|
Release Notes Persisted
|
This was referenced Oct 26, 2018
|
We have automatically backported this PR to "3-0-x", please check out #15421 |
|
We have automatically backported this PR to "4-0-x", please check out #15422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Resolves #15011.
Switches the default trash implementation away from
gvfs-trashtogio trashnow thatgvfs-trashhas ben largely deprecated and is no longer appropriate as the default./cc @ckerr @eli-schwartz
Checklist
npm testpassesRelease Notes
Notes: fix default trash impl on linux to use gio