8000 docs: deprecation warning for using nativeWindowOpen with nodeIntegration (4-0-x) by zcbenz · Pull Request #15193 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: deprecation warning for using nativeWindowOpen with nodeIntegration (4-0-x) #15193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2018
Merged

docs: deprecation warning for using nativeWindowOpen with nodeIntegration (4-0-x) #15193

merged 2 commits into from
Oct 17, 2018

Conversation

zcbenz
Copy link
Contributor
@zcbenz zcbenz commented Oct 16, 2018

Description of Change

Print a deprecation warning when the child windows opened with nativeWindowOpen option have node integration.

Refs #12634, #15076 (comment).

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: Print a deprecation warning when the child windows opened with nativeWindowOpen option have node integration.

@zcbenz zcbenz requested review from a team October 16, 2018 11:26
@codebytere
Copy link
Member

Need to fix TypeError: console.warn is not a function

@zcbenz
Copy link
Contributor Author
zcbenz commented Oct 17, 2018

It looks like the code is executed when did-stop-loading event happens, and the DOM may have not been ready at that time.

@zcbenz
Copy link
Contributor Author
zcbenz commented Oct 17, 2018

Delaying the warning to dom-ready has fixed the failed tests.

@zcbenz zcbenz merged commit 5fbf1f9 into 4-0-x Oct 17, 2018
@release-clerk
Copy link
release-clerk bot commented Oct 17, 2018

Release Notes Persisted

Print a deprecation warning when the child windows opened with nativeWindowOpen option have node integration.

@zcbenz zcbenz deleted the window-open-warn-leak-4-0-x branch October 17, 2018 02:54
@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcbenz @codebytere
0