8000 fix: do not create node environment in child window if node integration is not enabled (4-0-x) by zcbenz · Pull Request #15190 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: do not create node environment in child window if node integration is not enabled (4-0-x) #15190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

zcbenz
Copy link
Contributor
@zcbenz zcbenz commented Oct 16, 2018

Backport #15076 to 4-0-x.

Notes: Partially fix the memory leak when opening child windows with nativeWindowOpen.

@zcbenz zcbenz requested a review from a team October 16, 2018 09:16
@zcbenz zcbenz merged commit 0c09199 into 4-0-x Oct 16, 2018
@release-clerk
Copy link
release-clerk bot commented Oct 16, 2018

Release Notes Persisted

Partially fix the memory leak when opening child windows with nativeWindowOpen.

@zcbenz zcbenz deleted the no-node-integration-in-child-window-4-0-x branch October 16, 2018 10:25
@zcbenz zcbenz changed the title fix: do not create node environment in child window if node integration is not enabled fix: do not create node environment in child window if node integration is not enabled (4-0-x) Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0