fix: export zlib symbols #15103
Merged
fix: export zlib symbols #15103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Release Notes Persisted
|
|
We have automatically backported this PR to "4-0-x", please check out #15118 |
MarshallOfSound
added a commit
that referenced
this pull request
Oct 13, 2018
This reverts commit 47b12ee.
|
@adill we had to revert the change as it causes compilation errors on Windows in debug configuration. |
MarshallOfSound
added a commit
that referenced
this pull request
Oct 13, 2018
This reverts commit 47b12ee.
trop-bot
pushed a commit
to trop-bot/electron
that referenced
this pull request
Oct 13, 2018
This reverts commit 47b12ee.
trop-bot
pushed a commit
to trop-bot/electron
that referenced
this pull request
Oct 13, 2018
This reverts commit 47b12ee.
MarshallOfSound
added a commit
that referenced
this pull request
Oct 13, 2018
MarshallOfSound
pushed a commit
that referenced
this pull request
Oct 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Previous to 4.0.0 electron's
node.libincluded symbols for zlib; this restores that behavior. We've got one native module that was directly using the bundled zlib but I don't imagine we are the only ones?Checklist
Release Notes
Notes: export zlib symbols