8000 chore: warn when people attempt to use the Electron module to do Electron things but from node (backport: 4-0-x) by trop[bot] · Pull Request #15977 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: warn when people attempt to use the Electron module to do Electron things but from node (backport: 4-0-x) #15977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2018
Merged

chore: warn when people attempt to use the Electron module to do Electron things but from node (backport: 4-0-x) #15977

merged 2 commits into from
Dec 12, 2018

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Dec 8, 2018

Backport of #15916

See that PR for details.

Notes: Warn if you try to use Electron APIs from a non-electron environment

@trop trop bot requested a review from a team December 8, 2018 02:40
@trop trop bot mentioned this pull request Dec 8, 2018
Merged
@trop trop bot added 4-2-x backport This is a backport PR labels Dec 8, 2018
@codebytere codebytere merged commit 84d66c8 into electron:4-0-x Dec 12, 2018
@release-clerk
Copy link
release-clerk bot commented Dec 12, 2018

Release Notes Persisted

Warn if you try to use Electron APIs from a non-electron environment

@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
4-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @MarshallOfSound
0