feat: Upgrade to Chromium 71.0.3578.98 #15966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
reviewed
Dec 6, 2018
| - # Enables Widevine key system support. Enabled by default in Google Chrome or | ||
| - # on Android. Can be optionally enabled in Chromium. | ||
| - enable_widevine = is_chrome_branded || is_android | ||
| + # Allow Widevine key system support in Chromium. |
There was a problem hiding this comment.
nit: we don't need to patch this comment
11f7703 to
c557736
Compare
06cba7c to
ec4c329
Compare
|
I'm rebasing this branch to fix conflict with webview fixes. |
ec4c329 to
8e6ea7d
Compare
479c3cd to
5a24bfd
Compare
nornagon
reviewed
Jan 2, 2019
b82b054 to
957a3d3
Compare
c1e0e1d to
c8e461b
Compare
nornagon
reviewed
Jan 8, 2019
nornagon
reviewed
Jan 8, 2019
nornagon
reviewed
Jan 8, 2019
nornagon
reviewed
Jan 8, 2019
| @@ -182,30 +183,21 @@ void AtomSandboxedRendererClient::DidCreateScriptContext( | |||
| !IsDevToolsExtension(render_frame)) | |||
| return; | |||
|
|
|||
| // Wrap the bundle into a function that receives the binding object as | |||
| // argument. | |||
There was a problem hiding this comment.
is this comment still accurate?
There was a problem hiding this comment.
Yup the per process loader essentially does the same, it runs the provided source under a scope that has these arguments in the global variable.
nornagon
reviewed
Jan 8, 2019
| v8::Isolate* isolate = context->GetIsolate(); | ||
| v8::HandleScope handle_scope(isolate); | ||
| v8::Context::Scope context_scope(context); | ||
|
|
||
| // Wrap the bundle into a function that receives the isolatedWorld as | ||
| // an argument. |
There was a problem hiding this comment.
is this comment still accurate?
5572c19 to
f41f13b
Compare
nornagon
approved these changes
Jan 10, 2019
|
|
||
| namespace { | ||
|
|
||
| napi_value Print(napi_env env, napi_callback_info info) { |
There was a problem hiding this comment.
Why is this called Print? Perhaps it should be called Echo?
| try { | ||
| window.localStorage | ||
| } catch (e) { | ||
| message = e.message | ||
| const {ipcRenderer} = require('electron') | ||
| ipcRenderer.send('local-storage-response', e.message) | ||
| } |
There was a problem hiding this comment.
This looks like it won't send a message back if it doesn't throw, which will just make the test time out. Let's make tests fail fast & with useful error messages rather than dealing with yet another "test timed out" failure.
zcbenz
approved these changes
Jan 11, 2019
f41f13b to
7fa67e1
Compare
Due to the migration to Custom Elements V1, the WebView element has to be defined in the DOM's context. To order to make WebView work with the contextIsolation, the definition of WebView element has been moved to a separate file.
per frame scheme previlege api are no longer available, scheme needs to be registered on the browser side with AtomContentClient::AddAdditionalSchemes
7fa67e1 to
8bec8e5
Compare
|
Release Notes Persisted
|
akisctx
pushed a commit
to akisctx/electron
that referenced
this pull request
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs https://github.com/orgs/electron/projects/26
BREAKING CHANGE
Checklist
npm testpassesRelease Notes
Notes: Upgrade to Chromium 71.0.3578.98