8000 chore: restore kill_win.cc dcheck by nornagon · Pull Request #15630 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: restore kill_win.cc dcheck #15630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2018
Merged

chore: restore kill_win.cc dcheck #15630

merged 1 commit into from
Nov 8, 2018

Conversation

nornagon
Copy link
Contributor
@nornagon nornagon commented Nov 8, 2018

Description of Change

Restore a commented-out DCHECK in kill_win.cc
Notes: no-notes

@nornagon nornagon requested a review from a team November 8, 2018 01:51
Copy link
Member
@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be fixed now 👍

@jkleinsc jkleinsc self-requested a review November 8, 2018 14:40
Copy link
Member
@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkleinsc jkleinsc merged commit 673004b into master Nov 8, 2018
@release-clerk
Copy link
release-clerk bot commented Nov 8, 2018

No Release Notes

@jkleinsc jkleinsc deleted the restore-kill_win-dcheck branch November 8, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0