fix: roll node to fix fs.readSync bug #14118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can it be avoided, we don't have working GN in 3.x line. There is no harm in pulling those changes, just considering an option. |
|
@deepak1556 we're discussing this now, we'd like to avoid this as well. |
989f83a to
11aff63
Compare
|
Release Notes Persisted
|
This was referenced Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #13979.
This PR brings in electron/node@c86e3d3 in order to fix an issue with
fs.readSyncwhere large position values caused the function to work incorrectly.Also pulls in build files necessary to build Node with GN.
/cc @ckerr @nornagon
Checklist
npm testpassesRelease Notes
Notes: fixed a bug where fs.readSync worked incorrectly with large values of the
positionparam