8000 chore: remove dead code in menu controller by codebytere · Pull Request #14939 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: remove dead code in menu controller #14939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2018
Merged

chore: remove dead code in menu controller #14939

merged 1 commit into from
Oct 3, 2018

Conversation

codebytere
Copy link
Member
Description of Change

IsItemDynamicAt was never implemented, and Menus can't be altered dynamically like this at present so this codepath will never be exercised and can therefore be removed.

/cc @zcbenz

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: no-notes

@codebytere codebytere requested a review from a team October 3, 2018 06:13
@zcbenz zcbenz merged commit e06bc31 into master Oct 3, 2018
@release-clerk
Copy link
release-clerk bot commented Oct 3, 2018

No Release Notes

@zcbenz zcbenz deleted the rm-dead-menu-code branch October 3, 2018 07:24
@codebytere codebytere mentioned this pull request Feb 8, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @zcbenz
0