8000 docs: Add instructions on how to pull/push by felixrieseberg · Pull Request #14903 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: Add instructions on how to pull/push #14903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2018

Conversation

felixrieseberg
Copy link
Member
Description of Change

This PR documents how maintainers currently pull/push. This is likely not the best way to actually achieve our goal, but I'd love visitors and "outsiders" to know how we're doing it.

Checklist
  • PR description included and stakeholders cc'd
  • relevant documentation is changed or added
  • PR title follows semantic
Release Notes

Notes: Added documentation on how to pull/push with gclient

@felixrieseberg felixrieseberg requested review from nornagon and a team October 1, 2018 17:45
```sh
$ cd src/electron
$ git remote remove origin
$ git remote add origin https://github.com/electron/electron
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git remote set-url origin https://github.com/electron/electron

```sh
$ cd src/electron
$ git remote remove origin
$ git remote add origin https://github.com/electron/electron
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe git remote set-url origin instead of remote remove and remote add?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git remote set-url origin only sets both fetch and push if they are both the same, if they are not the same it only sets fetch and leaves push alone.

```sh
$ cd src/electron
$ git pull
$ cd ..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to cd back out to gclient sync, gclient will walk up the directory structure to find .gclient

```sh
$ cd src/electron
$ git pull
$ cd ..
Copy link
Contributor
@alexeykuzmin alexeykuzmin Oct 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to switch folders here.
gclient looks for its config in all ancestral folders.

$ cd -
```

:memo: `glient` works by checking a file called `DEPS` inside the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: glient -> gclient

@MarshallOfSound MarshallOfSound merged commit ca826d4 into master Oct 10, 2018
@release-clerk
Copy link
release-clerk bot commented Oct 10, 2018

Release Notes Persisted

Added documentation on how to pull/push with gclient

@MarshallOfSound MarshallOfSound deleted the document-gclient-pull branch October 10, 2018 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
0