-
Notifications
You must be signed in to change notification settings - Fork 16.2k
docs: Add instructions on how to pull/push #14903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
```sh | ||
$ cd src/electron | ||
$ git remote remove origin | ||
$ git remote add origin https://github.com/electron/electron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git remote set-url origin https://github.com/electron/electron
```sh | ||
$ cd src/electron | ||
$ git remote remove origin | ||
$ git remote add origin https://github.com/electron/electron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe git remote set-url origin
instead of remote remove
and remote add
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git remote set-url origin
only sets both fetch and push if they are both the same, if they are not the same it only sets fetch
and leaves push
alone.
```sh | ||
$ cd src/electron | ||
$ git pull | ||
$ cd .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to cd back out to gclient sync
, gclient
will walk up the directory structure to find .gclient
```sh | ||
$ cd src/electron | ||
$ git pull | ||
$ cd .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to switch folders here.
gclient
looks for its config in all ancestral folders.
$ cd - | ||
``` | ||
|
||
:memo: `glient` works by checking a file called `DEPS` inside the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: glient -> gclient
Release Notes Persisted
|
Description of Change
This PR documents how maintainers currently pull/push. This is likely not the best way to actually achieve our goal, but I'd love visitors and "outsiders" to know how we're doing it.
Checklist
Release Notes
Notes: Added documentation on how to pull/push with
gclient