10000 doc: correct key code reqs for accelerator doc by codebytere · Pull Request #14823 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

doc: correct key code reqs for accelerator doc #14823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Sep 26, 2018
Description of Change

Resolves #14818.

Clarifies that global accelerator registration can accept multiple modifiers but only one key code.

/cc @ckerr

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
Release Notes

Notes: correct key code allowance for accelerator doc

@codebytere codebytere requested a review from a team September 26, 2018 20:52
@codebytere
Copy link
Member Author

Unrelated test failures, merging since this is just a docs PR.

@codebytere codebytere merged commit be2c27d into master Sep 26, 2018
@release-clerk
Copy link
release-clerk bot commented Sep 26, 2018

Release Notes Persisted

correct key code allowance for accelerator doc

@codebytere
Copy link
Member Author

/trop run backport-to 3-0-x,2-0-x

@trop
Copy link
Contributor
trop bot commented Sep 26, 2018

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "3-0-x" here we go! :D

@trop
Copy link
Contributor
trop bot commented Sep 26, 2018

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "2-0-x" here we go! :D

@trop
Copy link
Contributor
trop bot commented Sep 26, 2018

We have automatically backported this PR to "3-0-x", please check out #14824

@trop
Copy link
Contributor
trop bot commented Sep 26, 2018

We have automatically backported this PR to "2-0-x", please check out #14825

@trop trop bot added the merged/2-0-x label Sep 26, 2018
@ckerr ckerr changed the title docs: correct key code reqs for accelerator doc doc: correct key code reqs for accelerator doc Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0