8000 fix: send null in debugger callback when no error by MarshallOfSound · Pull Request #14814 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: send null in debugger callback when no error #14814

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2018
Merged

fix: send null in debugger callback when no error #14814

merged 1 commit into from
Sep 27, 2018

Conversation

MarshallOfSound
Copy link
Member
@MarshallOfSound MarshallOfSound commented Sep 26, 2018 •
edited
Loading

Fixes #14811

All node style callbacks should have null in the error slot when no error is present, basically all callback based code has logic like

if (err) return logError(err);

Notes: debugger command callbacks now run with null as the error when no error has occurred

@MarshallOfSound MarshallOfSound requested a review from a team September 26, 2018 05:27
@MarshallOfSound MarshallOfSound merged commit 7dc7cd1 into master Sep 27, 2018
@release-clerk
Copy link
release-clerk bot commented Sep 27, 2018

Release Notes Persisted

debugger command callbacks now run with null as the error when no error has occurred

@MarshallOfSound MarshallOfSound deleted the null-debugger-error branch September 27, 2018 07:43
codebytere pushed a commit that referenced this pull request Sep 27, 2018
@MarshallOfSound @codebytere
fix: send null in debugger callback when no error (#14814)
2470078 
Fixes #13811
@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codeb 51D4 ytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarshallOfSound @codebytere
0