8000 docs: fix `second-instance` handler signature example by inukshuk · Pull Request #14731 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: fix second-instance handler signature example #14731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2018
Merged

docs: fix second-instance handler signature example #14731

merged 1 commit into from
Sep 21, 2018

Conversation

inukshuk
Copy link
Contributor
@inukshuk inukshuk commented Sep 20, 2018 •
edited by ckerr
Loading
Description of Change

Fix the event handler signature in the 'second-instance' event handler example.

Checklist
  • PR description included and stakeholders cc'd
Release Notes:

Notes: Fixed second-instance API documentation error.

@inukshuk inukshuk requested a review from a team September 20, 2018 13:02
@welcome
Copy link
welcome bot commented Sep 20, 2018

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@inukshuk inukshuk changed the title Documentation: fix second-instance handler signature in sample code docs: fix second-instance handler signature example Sep 20, 2018
ckerr
ckerr approved these changes Sep 20, 2018
View reviewed changes
Copy link
Member
@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@codebytere codebytere merged commit a24307b into electron:master Sep 21, 2018
@release-clerk
Copy link
release-clerk bot commented Sep 21, 2018

Release Notes Persisted

Fixed second-instance API documentation error.

@welcome
Copy link
welcome bot commented Sep 21, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@trop
Copy link
Contributor
trop bot commented Sep 21, 2018

We have automatically backported this PR to "3-0-x", please check out #14748

@trop trop bot mentioned this pull request Sep 21, 2018
Merged
@trop trop bot added merged/3-0-x and removed target/3-0-x labels Sep 21, 2018
@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inukshuk @ckerr @codebytere
0