8000 refactor: deprecation handling apis by codebytere · Pull Request #14615 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: deprecation handling apis #14615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2018
Merged

refactor: deprecation handling apis #14615

merged 1 commit into from
Sep 14, 2018

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Sep 13, 2018 •
edited
Loading
Description of Change

Combination backport of #14495 and #14579.

Fixes issue whereby we were printing:

(electron) The 'privateBytes' property of function getAppMetrics() { [native code] } has been deprecated and marked for removal.

/cc @ckerr

Checklist
Release Notes

Notes: no-notes

@codebytere codebytere requested a review from a team September 13, 2018 17:36
ckerr
ckerr reviewed Sep 14, 2018
View reviewed changes
Copy link
Member
@ckerr ckerr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting to say thanks for keeping me in the loop 👍

Not reviewing because so much of this is a backport of the deprecate refactor I wrote

@codebytere codebytere merged commit 89148bc into 3-0-x Sep 14, 2018
@release-clerk
Copy link
release-clerk bot commented Sep 14, 2018

No Release Notes

@MarshallOfSound MarshallOfSound deleted the bp-deprecation branch September 14, 2018 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr left review comments

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @ckerr @MarshallOfSound
0