8000 Refactoring: use C++11 class member variable initialization by miniak · Pull Request #13030 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactoring: use C++11 class member variable initialization #13030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2018
Merged

Refactoring: use C++11 class member variable initialization #13030

merged 1 commit into from
May 22, 2018

Conversation

miniak
Copy link
Contributor
@miniak miniak commented May 21, 2018

No description provided.

@miniak miniak requested review from a team May 21, 2018 22:22
zcbenz
zcbenz approved these changes May 22, 2018
View reviewed changes
Copy link
Contributor
@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

deepak1556
deepak1556 approved these changes May 22, 2018
View reviewed changes
Copy link
Member
@deepak1556 deepak1556 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks! For clarity, this is allowed in chromium style guide https://groups.google.com/a/chromium.org/d/msg/chromium-dev/zqB-DySA4V0/9SWmPtdE-fwJ

@thomasjo
Copy link
Contributor

This definitely improves readability/discoverability. Great work ❤️

@jkleinsc jkleinsc merged commit c320da5 into master May 22, 2018
@jkleinsc jkleinsc deleted the miniak/member-init branch May 22, 2018 14:34
@miniak miniak mentioned this pull request Jul 13, 2018
Merged
5 tasks
@miniak miniak mentioned this pull request Jan 25, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miniak @thomasjo @zcbenz @deepak1556 @jkleinsc
0