8000 docs: fix typos in security.md by GhostlyDark · Pull Request #13999 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: fix typos in security.md #13999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2018
Merged

docs: fix typos in security.md #13999

merged 1 commit into from
Aug 9, 2018

Conversation

GhostlyDark
Copy link
Contributor

Fixes the typos mentioned in #13943

@GhostlyDark GhostlyDark requested a review from a team August 9, 2018 14:49
@welcome
Copy link
welcome bot commented Aug 9, 2018

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

ckerr
ckerr approved these changes Aug 9, 2018
View reviewed changes
Copy link
Member
@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! 👍

@ckerr ckerr merged commit 9005803 into electron:master Aug 9, 2018
@welcome
Copy link
welcome bot commented Aug 9, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@trop trop bot mentioned this pull request Aug 9, 2018
Merged
@trop
Copy link
Contributor
trop bot commented Aug 9, 2018

We have automatically backported this PR to "3-0-x", please check out #14001

@trop trop bot added merged/3-0-x and removed target/3-0-x labels Aug 9, 2018
@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
documentation 📓
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GhostlyDark @ckerr
0