8000 feat: add location url to "Node.js Integration with Remote Content" warning by ckerr · Pull Request #13973 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add location url to "Node.js Integration with Remote Content" warning #13973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2018
Merged

feat: add location url to "Node.js Integration with Remote Content" warning #13973

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b893e7
docs: fix typo
ckerr Aug 7, 2018
742eb57
feat: add location url to Node+Remote warning
ckerr Aug 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
8000
Diff view
6 changes: 3 additions & 3 deletions lib/renderer/security-warnings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const shouldLogSecurityWarnings = function () {
}

/**
* Check's if the current window is remote.
* Checks if the current window is remote.
*
* @returns {boolean} - Is this a remote protocol?
*/
Expand Down Expand Up @@ -137,8 +137,8 @@ module.exports = {
warnAboutNodeWithRemoteContent: () => {
if (getIsRemoteProtocol()) {
const warning = `This renderer process has Node.js integration enabled
and attempted to load remote content. This exposes users of this app to
severe security risks.\n ${moreInformation}`
and attempted to load remote content from '${window.location}'. This
exposes users of this app to severe security risks.\n ${moreInformation}`

console.warn('%cElectron Security Warning (Node.js Integration with Remote Content)',
'font-weight: bold;', warning)
Expand Down
0