8000 fix: Prevent menu update while it's open (backport: 2-0-x) by sethlu · Pull Request #13966 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Prevent menu update while it's open (backport: 2-0-x) #13966

New issue
Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2018
Merged

fix: Prevent menu update while it's open (backport: 2-0-x) #13966

merged 3 commits into from
Aug 7, 2018

Conversation

sethlu
Copy link
Contributor
@sethlu sethlu commented Aug 7, 2018

Backport of #12809

See above PR for details.

sethlu added 3 commits August 6, 2018 23:49
@sethlu
Update application menu on default runloop
67b1013 
Menu change should be prevented while the menu is open
@sethlu
8000
Fix code style
79caff6
@sethlu
Memory safety
dd89aa6
@sethlu sethlu requested a review from a team August 7, 2018 06:54
@MarshallOfSound MarshallOfSound added the backport This is a backport PR label Aug 7, 2018
@jkleinsc jkleinsc merged commit bdc255f into 2-0-x Aug 7, 2018
@jkleinsc jkleinsc deleted the 2-0-x-backport-12809 branch August 7, 2018 14:10
@daviwil daviwil mentioned this pull request Aug 9, 2018
Merged
1 task
@bpasero bpasero mentioned this pull request Aug 20, 2018
Closed
@shiftkey shiftkey mentioned this pull request Aug 26, 2018
Closed
4 task 7CB9 s
@sethlu sethlu mentioned this pull request Sep 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sethlu @codebytere @MarshallOfSound @jkleinsc
0