8000 fix: some APIs modified for ASAR support cannot be util.promisify'ed (backport: 2-0-x) by miniak · Pull Request #13960 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: some APIs modified for ASAR support cannot be util.promisify'ed (backport: 2-0-x) #13960

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2018
Merged

fix: some APIs modified for ASAR support cannot be util.promisify'ed (backport: 2-0-x) #13960

merged 1 commit into from
Aug 7, 2018

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Aug 6, 2018 •
edited
Loading

Backport #13845

Checklist

@miniak miniak requested a review from a team August 6, 2018 22:19
@miniak miniak force-pushed the miniak/fix-promisify-2.0 branch from 724b47f to 6a86831 Compare August 6, 2018 22:21
@miniak
Copy link
Contributor Author
miniak commented Aug 6, 2018

the failing tests on Windows are unrelated to my change

not ok 47 app module mixed sandbox option when app.enableMixedSandbox() is called adds --enable-sandbox to render processes created with sandbox: true
  Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
      at C:\projects\electron-39ng6\spec\node_modules\mocha\lib\runnable.js:232:19
not ok 48 app module mixed sandbox option when the app is launched with --enable-mixed-sandbox adds --enable-sandbox to render processes created with sandbox: true
  Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
      at C:\projects\electron-39ng6\spec\node_modules\mocha\lib\runnable.js:232:19

@codebytere
Copy link
Member

@miniak those tests are suppressed on master and being addressed separately

@jkleinsc jkleinsc merged commit e8e542b into 2-0-x Aug 7, 2018
@jkleinsc jkleinsc deleted the miniak/fix-promisify-2.0 branch August 7, 2018 14:05
@daviwil daviwil mentioned this pull request Aug 9, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miniak @codebytere @jkleinsc
0