10000 fix: add missing "simple" property in several APIs to prevent proxying of return values by miniak · Pull Request #13905 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add missing "simple" property in several APIs to prevent proxying of return values #13905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2018
Merged

fix: add missing "simple" property in several APIs to prevent proxying of return values #13905

merged 2 commits into from
Aug 3, 2018

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Aug 1, 2018 •
edited
Loading

Fixes the the following APIs

  • app.getAppMetrics()
  • process.getHeapStatistics()
  • process.getProcessMemoryInfo()
  • process.getSystemMemoryInfo()
  • process.getCPUUsage()
  • process.getIOCounters()

I have also converted api-process-spec.js to chai / expect

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are [changed or added]
  • PR title follows semantic commit guidelines

@miniak miniak requested review from a team, zcbenz and MarshallOfSound August 1, 2018 10:21
@miniak miniak force-pushed the miniak/simple-object branch from ab2b0e9 to bf162c6 Compare August 1, 2018 10:23
codebytere
codebytere approved these changes Aug 1, 2018
View reviewed changes
Copy link
Member
@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@miniak
Copy link
Contributor Author
miniak commented Aug 3, 2018

@codebytere can you please merge?

@miniak
Copy link
Contributor Author
miniak commented Aug 3, 2018

@MarshallOfSound is this change considered breaking? I would like to backport this to 3.0

@codebytere
Copy link
Member

@nornagon how concerned should i be about the GN failures?

@codebytere codebytere merged commit f904057 into master Aug 3, 2018
@zeke zeke deleted the miniak/simple-object branch August 3, 2018 20:25
@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miniak @codebytere
0