docs: update node upgrade doc #13891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykuzmin
reviewed
Aug 1, 2018
docs/development/upgrading-node.md
Outdated
| 6. Read `patches/common/v8/README.md` to see which patchfiles came from the previous version of V8 and therefore need to be removed. | ||
| - Delete each patchfile referenced in `patches/common/v8/README.md` | ||
| 7. Apply all patches with the `get-patch` script: | ||
| - `./script/get-patch --repo src/v8 --output_-dir patches/v8 --commit abc123 def456 ... --filename backport_abc123.patch cherry-pick_def456.patch` |
alexeykuzmin
suggested changes
Aug 1, 2018
docs/development/upgrading-node.md
Outdated
| 6. Read `patches/common/v8/README.md` to see which patchfiles came from the previous version of V8 and therefore need to be removed. | ||
| - Delete each patchfile referenced in `patches/common/v8/README.md` | ||
| 7. Apply all patches with the `get-patch` script: | ||
| - `./script/get-patch --repo src/v8 --output_-dir patches/v8 --commit abc123 def456 ... --filename backport_abc123.patch cherry-pick_def456.patch` |
There was a problem hiding this comment.
--filename backport_abc123.patch cherry-pick_def456.patch
Can we "recommend" to use default patchfile names here? Simply by omitting the --filename arg.
docs/development/upgrading-node.md
Outdated
| @@ -115,7 +87,7 @@ We need to generate a patch file from each patch applied to V8. | |||
| electron/vendor/libchromiumcontent$ git checkout upgrade-to-chromium-X | |||
| electron/vendor/libchromiumcontent$ cd ../.. | |||
| electron$ git add vendor | |||
| electron$ git commit -m "update submodule referefences for node and libc" | |||
| electron$ git commit -m "update submodule references for node and libc" | |||
There was a problem hiding this comment.
and libc"
Probably should read "libcc".
docs/development/upgrading-node.md
Outdated
| @@ -115,7 +87,7 @@ We need to generate a patch file from each patch applied to V8. | |||
| electron/vendor/libchromiumcontent$ git checkout upgrade-to-chromium-X | |||
| electron/vendor/libchromiumcontent$ cd ../.. | |||
| electron$ git add vendor | |||
| electron$ git commit -m "update submodule referefences for node and libc" | |||
| electron$ git commit -m "update submodule references for node and libc" | |||
| electron$ git pso upgrade-to-chromium-62 | |||
docs/development/upgrading-node.md
Outdated
| - `git rm` the patchfiles | ||
| - edit `patches/v8/README.md` | ||
| - edit `patches/common/v8/README.md` | ||
| - commit these removals | ||
| 4. Inspect Node [repo](https://github.com/electron/node) to see what patches upstream Node | ||
| used with their v8 after bumping its version | ||
| - `git log --oneline deps/V8` |
There was a problem hiding this comment.
deps/V8
Should be "deps/v8".
docs/development/upgrading-node.md
Outdated
| 8. Update `patches/v8/README.md` with references to all new patches that have been added so that the next person will know which need to be removed. | ||
| 6. Read `patches/common/v8/README.md` to see which patchfiles came from the previous version of V8 and therefore need to be removed. | ||
| - Delete each patchfile referenced in `patches/common/v8/README.md` | ||
| 7. Apply all patches with the `get-patch` script: |
There was a problem hiding this comment.
the
get-patchscript
Should it be a link to https://github.com/electron/libchromiumcontent/blob/master/script/README.md#get-patch ?
alexeykuzmin
approved these changes
Aug 1, 2018
MarshallOfSound
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
upgrading-node.mddoc for latest paths and script commands./cc @alexeykuzmin
Checklist