8000 docs: update release docs from Fri 13 release session by ckerr · Pull Request #13664 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: update release docs from Fri 13 release session #13664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 16, 2018
Merged

docs: update release docs from Fri 13 release session #13664

merged 5 commits into from
Jul 16, 2018

Conversation

ckerr
Copy link
Member
@ckerr ckerr commented Jul 13, 2018

Improve documentation as per today's release session of 2.0.5:

  • Fix VSTS token URL
  • Add note about avoiding multiple builds on subsequent calls to validateRelease
  • Document the ELECTRON_S3_* tokens
  • Add post-publish npm dist-tag ls electron step
Checklist

@ckerr ckerr requested review from jkleinsc and a team July 13, 2018 21:50
zeke
zeke approved these changes Jul 14, 2018
View reviewed changes
Copy link
Contributor
@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though the underscore inhttps://github.visualstudio.com/_details seems to start a markdown bold block that breaks the GitHub markdown parser.

@zeke
Copy link
Contributor
zeke commented Jul 14, 2018

You can safely ignore the pending status from Semantic Pull Request here. This will be resolved by zeke/semantic-pull-requests#13

Fix formatting
5764d76 
Add alternate url for security token (depends on whether you are using new or old navigation on VSTS)
jkleinsc
jkleinsc approved these changes Jul 16, 2018
View reviewed changes
Copy link
Member
@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ckerr it turns out that the URL for VSTS depends on whether you are using the new navigation or the old navigation for VSTS. I updated the doc to include both and fixed a formatting issue that was there previously.

@jkleinsc jkleinsc merged commit cc03213 into master Jul 16, 2018
@jkleinsc jkleinsc deleted the tweak-release-docs branch July 16, 2018 20:22
@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeke zeke zeke approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckerr @zeke @jkleinsc
0