8000 fix: enable webview in sandbox renderer (#13435) by juturu · Pull Request #13555 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: enable webview in sandbox renderer (#13435) #13555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 27, 2018
Merged

fix: enable webview in sandbox renderer (#13435) #13555

merged 3 commits into from
Nov 27, 2018

Conversation

juturu
Copy link
Contributor
@juturu juturu commented Jul 4, 2018 •
edited by zcbenz
Loading

Notes: Enable webview in sandbox renderer
Security: Inherit embedder prefs onto webview

@juturu juturu requested review from a team, tarruda and MarshallOfSound July 4, 2018 01:48
@alexeykuzmin
Copy link
Contributor 
spec/api-browser-window-spec.js:1591:9: 'expect' is not defined.

@juturu
Copy link
Contributor Author
juturu commented Jul 4, 2018

@alexeykuzmin thanks. Fixed the expect issue.

@juturu juturu closed this Jul 4, 2018
@juturu juturu reopened this Jul 4, 2018
@jkleinsc jkleinsc force-pushed the backport-webview-sandbox-renderer-2-0-x branch from 872c111 to 18cd014 Compare July 17, 2018 14:06
@MarshallOfSound
Copy link
Member

@juturu It looks like this is hanging the tests, not sure how 🤔

@codebytere
Copy link
Member

@juturu are you still interested in landing this?

@juturu @zcbenz
Enable webview in sandbox renderer (#13435)
70163e8 
* Enable webview in sandbox renderer
Security: Inherit embedder prefs onto webview

* cache lastwebprefs
@juturu @zcbenz
fix expect UT issue
2bb0e83
@zcbenz zcbenz force-pushed the backport-webview-sandbox-renderer-2-0-x branch from 18cd014 to 2bb0e83 Compare November 27, 2018 07:00
@zcbenz zcbenz changed the title Enable webview in sandbox renderer (#13435) fix: enable webview in sandbox renderer (#13435) Nov 27, 2018
@zcbenz
Copy link
Contributor
zcbenz commented Nov 27, 2018

The tests is hanging because events-helpers is not available in 2-0-x's source code, I have fixed the tests.

@zcbenz zcbenz force-pushed the backport-webview-sandbox-renderer-2-0-x branch from 01eb672 to da60f51 Compare November 27, 2018 07:38
@zcbenz zcbenz merged commit 9313af3 into 2-0-x Nov 27, 2018
@release-clerk
Copy link
release-clerk bot commented Nov 27, 2018

Release Notes Persisted

Enable webview in sandbox renderer

@zcbenz zcbenz deleted the backport-webview-sandbox-renderer-2-0-x branch November 27, 2018 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@Akshat-Jain Akshat-Jain Akshat-Jain approved these changes

@tarruda tarruda Awaiting requested review from tarruda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@juturu @alexeykuzmin @MarshallOfSound @codebytere @zcbenz @Akshat-Jain
0