8000 Set appropriate defaults for webview options by ckerr · Pull Request #12271 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Set appropriate defaults for webview options #12271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 15, 2018
Merged

Set appropriate defaults for webview options #12271

merged 5 commits into from
Mar 15, 2018

Conversation

ckerr
Copy link
Member
@ckerr ckerr commented Mar 14, 2018 •
edited by MarshallOfSound
Loading

Ensure that the webview options object has appropriate default values.

Details at https://www.electronjs.org/blog/webview-fix

@ckerr ckerr requested a review from a team March 14, 2018 11:43
@MarshallOfSound MarshallOfSound force-pushed the set-appropriate-defaults-for-webview-options branch from 6f20526 to 72a051b Compare March 15, 2018 02:37
@MarshallOfSound MarshallOfSound merged commit c2673aa into master Mar 15, 2018
@trop trop bot mentioned this pull request Mar 15, 2018
Merged
@trop
Copy link
Contributor
trop bot commented Mar 15, 2018

We have automatically backported this PR to "2-0-x", please check out #12292

@trop trop bot added merged/2-0-x and removed target/2-0-x labels Mar 15, 2018
MarshallOfSound added a commit that referenced this pull request Mar 15, 2018
@MarshallOfSound
Revert "Set appropriate defaults for webview options (#12271)"
cfcce1f 
This reverts commit c2673aa.
@YurySolovyov
Copy link
Contributor

Link gives me 404

@MarshallOfSound MarshallOfSound mentioned this pull request Mar 15, 2018
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2018
@MarshallOfSound @codebytere
Revert "Fixes #12147" (#12293)
4b476f1 
* Revert "Set appropriate defaults for webview options (#12271)"

This reverts commit c2673aa.

* Revert "Fixes #12147 (#12193)"

This reverts commit f54c94d.
@zcbenz zcbenz deleted the set-appropriate-defaults-for-webview-options branch April 2, 2018 12:07
@gasi-signal gasi-signal mentioned this pull request Apr 13, 2018
Closed
sethlu pushed a commit to sethlu/electron that referenced this pull request May 3, 2018
@ckerr @sethlu
Set appropriate defaults for webview options (electron#12271)
168ae02 
* Persist defaults to webPreferences object to JS land can read the inferred values instead of just user defined values

* Test inherited default propogation

* Refactor to remove coupling from fetching values and defaults

* Test description type

* Fix up tests
sethlu pushed a commit to sethlu/electron that referenced this pull request May 3, 2018
@MarshallOfSound @sethlu
Revert "Fixes electron#12147" (electron#12293)
de89a19 
* Revert "Set appropriate defaults for webview options (electron#12271)"

This reverts commit c2673aa.

* Revert "Fixes electron#12147 (electron#12193)"

This reverts commit f54c94d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None 446A yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckerr @YurySolovyov @MarshallOfSound
0