8000 add missing report.length > 1 assertion by MarshallOfSound · Pull Request #12257 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add missing report.length > 1 assertion #12257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2018
Merged

add missing report.length > 1 assertion #12257

merged 1 commit into from
Mar 14, 2018

Conversation

MarshallOfSound
Copy link
Member

😄

@MarshallOfSound MarshallOfSound requested a review from a team March 14, 2018 02:26
ckerr
ckerr approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member
@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚

@ckerr ckerr merged commit 90dc897 into master Mar 14, 2018
@ckerr ckerr deleted the sorry-ckerr branch March 14, 2018 04:14
@trop
Copy link
Contributor
trop bot commented Mar 14, 2018

An error occurred while attempting to backport this PR to "2-0-x", you will need to perform this backport manually

@MarshallOfSound MarshallOfSound restored the sorry-ckerr branch March 14, 2018 04:22
@MarshallOfSound
Copy link
Member Author

/trop run backport

@trop
Copy link
Contributor
trop bot commented Mar 14, 2018

The backport process for this PR has been manually initiated, here we go! :D

@trop trop bot mentioned this pull request Mar 14, 2018
Merged
@trop
Copy link
Contributor
trop bot commented Mar 14, 2018

We have automatically backported this PR to "2-0-x", please check out #12262

@trop trop bot added merged/2-0-x and removed target/2-0-x labels Mar 14, 2018
@MarshallOfSound MarshallOfSound deleted the sorry-ckerr branch March 14, 2018 04:26
sethlu pushed a commit to sethlu/electron that referenced this pull request May 3, 2018
@MarshallOfSound @sethlu
add missing report.length > 1 assertion (electron#12257)
588c6c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarshallOfSound @ckerr
0