8000 Backport (2-0-x) - Handle in-app-purchase less fatally on non-Darwin by trop[bot] · Pull Request #12512 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Backport (2-0-x) - Handle in-app-purchase less fatally on non-Darwin #12512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2018
Merged

Backport (2-0-x) - Handle in-app-purchase less fatally on non-Darwin #12512

merged 1 commit into from
Apr 3, 2018

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Apr 2, 2018

Backport of #12511

See that PR for details.

@ckerr @electron-bot
Handle in-app-purchase less fatally on non-Darwin
88d84d9 
Right now it throws a new error, but this isn't ideal as there
are cases where everything is mass-required, such as Spectron.
Instead, we should throw an error on non-Darwin environments
only when the IAP methods are invoked.
@trop trop bot requested a review from a team April 2, 2018 23:57
@trop trop bot mentioned this pull request Apr 2, 2018
Merged
@trop trop bot added the backport This is a backport PR label Apr 2, 2018
@ckerr ckerr merged commit 33aad6a into electron:2-0-x Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ckerr
0