read files from asar archives in custom protocol #1199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| base::SequencedWorkerPool::SKIP_ON_SHUTDOWN)); | ||
| } else { | ||
| typedef std::shared_ptr<asar::Archive> asar_ptr; | ||
| asar_ptr archive = asar::GetOrCreateAsarArchive(asar_path); |
There was a problem hiding this comment.
You can use auto here if you don't want to type long type name.
3d76f9d to
2ce42af
Compare
|
Fixed lint , thanks! |
| real_job_ = new net::URLRequestErrorJob( | ||
| request(), | ||
| network_delegate(), | ||
| net::ERR_FILE_NOT_FOUND); |
There was a problem hiding this comment.
had to change this way to fix cpplint warning of 80 characters :(
|
Thanks! |
zcbenz
added a commit
that referenced
this pull request
Mar 5, 2015
read files from asar archives in custom protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1069