8000 fix: manually set spellchecker for sub frames in 1.8.x by deepak1556 · Pull Request #11489 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: manually set spellchecker for sub frames in 1.8.x #11489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2017
Merged

fix: manually set spellchecker for sub frames in 1.8.x #11489

merged 1 commit into from
Dec 20, 2017

Conversation

deepak1556
Copy link
Member

Backports #11238

Refs #11147

@deepak1556 deepak1556 requested a review from a team December 20, 2017 19:46
@deepak1556 deepak1556 force-pushed the 1-8-spellchecker-iframe-patch branch from 5682648 to d0a9379 Compare December 20, 2017 19:48
@deepak1556 deepak1556 requested a review from ckerr December 20, 2017 19:48
ckerr
ckerr approved these changes Dec 20, 2017
View reviewed changes
Copy link
Member
@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ckerr ckerr merged commit 19d70e5 into 1-8-x Dec 20, 2017
@ckerr
Copy link
Member
ckerr commented Dec 20, 2017

@deepak1556, thanks for the 1-8-x backport!

By any chance do you have time to backport #11385 and electron/libchromiumcontent#417?

@alexeykuzmin
Copy link
Contributor

to backport #11385

@deepak1556
This is non-trivial btw. In the 1-8-x branch we still have async menus, while in the master we don't.

@alexeykuzmin alexeykuzmin deleted the 1-8-spellchecker-iframe-patch branch December 20, 2017 22:29
@deepak1556
Copy link
Member Author

By any chance do you have time to backport #11385 and electron/libchromiumcontent#417?

Sure, I can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepak1556 @ckerr @alexeykuzmin
0